Skip to content

Add telemetry for new tab menu traffic #19142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

Adds new telemetry events to track traffic through the new tab menu. Specifically, the following events are added:

  • NewTabMenuDefaultButtonClicked: Event emitted when the default button from the new tab split button is invoked
  • NewTabMenuOpened: Event emitted when the new tab menu is opened
  • NewTabMenuClosed: Event emitted when the new tab menu is closed
  • NewTabMenuItemClicked: Event emitted when an item from the new tab menu is invoked
    • Has an ItemType parameter that can be set to Settings, CommandPalette, About, Profile, Action`
    • Has a TabCount parameter that keeps tracked of the number of tabs in the window before changing the state
  • NewTabMenuCreatedNewTerminalSession: Event emitted when a new terminal was created via the new tab menu
    • Has a SessionType parameter that can be set to ElevatedWindow, Window, Pane, Tab
    • Instead of TabCount, has a NewTabCount that keeps track of the new number of tabs after the session has been created
  • NewTabMenuItemElevateSubmenuItemClicked: Event emitted when the elevate submenu item from the new tab menu is invoked

Validation Steps Performed

Used TVPP to see events generated from interacting with the new tab menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant