Merge TabBase+TerminalTab into just Tab #19136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
commented
Jul 16, 2025
| @@ -1559,7 +1558,8 @@ namespace winrt::TerminalApp::implementation | |||
| activeTab->ToggleBroadcastInput(); | |||
| args.Handled(true); | |||
| } | |||
| // If the focused tab wasn't a TerminalTab, then leave handled=false | |||
| // TODO(DH) | |||
There was a problem hiding this comment.
I marked this todo not in the scope of this PR, but because after Mike's rewrite we never left handled=false. There will always be a sender or focused tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still some work to do around the cluster of...
Closes #17529