-
Notifications
You must be signed in to change notification settings - Fork 8.7k
feat: add option to enable zoom with ctrl + scroll
#19127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to enable zoom with ctrl + scroll
#19127
Conversation
Introduces a setting to prevent font zooming when using Ctrl+mouse wheel, giving users more control over accidental zoom actions.
Just wondering if instead of being "Disable zooming with Ctrl+mouse wheel" the option was switched to the other way and was "Zoom with Ctrl+mouse wheel". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself is solid. Thanks for doing this! 😊
My only holdup is the wording used. I think it's worth avoiding the double negative as @Lo0oG mentioned.
Some other miscellaneous work here:
- please update the docs on our docs repo
- update the list of references and relevant issues to use the "Closes" keyword
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
@carlos-zamora it's actually not. It does not work, and the standard for our project is indeed to put each Closes on its own line. |
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
…resw Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
c0e5e68
to
4e915d0
Compare
Thanks for the reviews and comments! I've addressed them. I'll open a PR for the docs update shortly 😃 |
ctrl + mouse wheel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only thing is that we should set the default value to true
throughout. That way, we don't accidentally disable it for everybody haha. But I think that's the last bit of feedback I have. Good work! 😊
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jsoref This is a weird case. This PR includes the spelling 0.0.25 changes from main, and it has run and passed, but all the Report phases are being "Skipped" (?) and we aren't getting "security scanning" results. I'm sure I'm just missing something, but... wat |
https://github.com/microsoft/terminal/actions/runs/16312069474/job/46126597737#step:2:12
I'd have to trace ... https://github.com/microsoft/terminal/actions/runs/16312069474/workflow#L107
Sigh. Just change this to I think I must have changed it for a different Microsoft repository. |
|
Yep, change that line to just I've updated https://docs.check-spelling.dev/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset.html#migration |
Thanks @jsoref - just merged that in 🙂 |
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…resw Co-authored-by: Dustin L. Howett <dustin@howett.net>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
thank you so much - folks are gonna love it |
Summary of the Pull Request
Introduces a setting to enable/disable font size changes in the terminal when holding Ctrl and scrolling, giving users more control over zoom actions.
References and Relevant Issues
#11710
#5708
#3793
#11906
#3990
#14627
Detailed Description of the Pull Request / Additional comments
This PR adds a new global setting
scrollToZoom
that allows users to enable font zooming with scrolling. When disabled, this setting prevents accidental font size changes that can occur when users scroll while holding the Ctrl key.Note: after disabling this setting, users may still change font size using
Ctrl+
andCtrl-
keyboard shortcuts. Other Ctrl+Scroll functionality (like transparency adjustments) remains unaffected.Validation Steps Performed
Invoke-OpenConsoleBuild -m "-p:Configuration=Release,Platform=x64"
and registered it using\repos\terminal\src\cascadia\CascadiaPackage\bin\x64\Release\AppxManifest.xml
Confirmed that when disabled, holding Ctrl and scrolling no longer changes font size
Validated that the setting persists across terminal restarts
PR Checklist
Summary: Total=278, Passed=278, Failed=0, Blocked=0, Not Run=0, Skipped=0
experimental.scrollToZoom
setting MicrosoftDocs/terminal#871Note: I used the existing
FocusFollowMouse
setting as a reference for implementing this.