Skip to content

Restore reruns for flaky tests #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Restore reruns for flaky tests #1982

merged 1 commit into from
Aug 27, 2024

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented Aug 27, 2024

What does this PR do?

In #1981 I noticed that the tests weren't actually run for some reason and the PR got merged while I was trying to figure out what went wrong. This PR restores the reuns - for some reason it is still only showing 2 checks, but I propose we merge and see if main works as intended

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@lewtun lewtun changed the title Restore test Aug 27, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lewtun lewtun marked this pull request as ready for review August 27, 2024 08:28
@lewtun lewtun requested a review from kashif August 27, 2024 08:28
@qgallouedec
Copy link
Member

but I propose we merge and see if main works as intended

ok

@lewtun lewtun merged commit 0cda2f2 into main Aug 27, 2024
2 checks passed
@lewtun lewtun deleted the fix-test-again branch August 27, 2024 09:16
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants